Repository navigation
Conversation
…and adopts the other's delta (sgl-project#87) When an earlier session turn had no M-RoPE delta, merge() dropped the new turn's delta, and it never cleared mrope_position_delta_repeated_cache, so decode positions after a multimodal session continuation came from a stale or missing delta. Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
rodamani
marked this pull request as ready for review
September 29, 2026 21:13
rodamani
requested review from
Ying1123,
hnyls2002,
merrymercy and
xiezhq-hermann
as code owners
September 29, 2026 21:13
Contributor
Author
|
/rerun-test -c |
Contributor
|
Results for ⛔ |
Contributor
Author
|
/tag-and-rerun-ci |
3 of 5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MultimodalInputs.merge(session continuation) drops the new turn's M-RoPE position delta when the earlier turn had none, and never clearsmrope_position_delta_repeated_cache. Decode positions after a multimodal session continuation then come from a stale or missing delta.Modifications
merge()adopts the other input's delta when self has none, and always clearsmrope_position_delta_repeated_cache.test/registered/unit/managers/test_mm_inputs_merge_mrope_delta.py.Accuracy Tests
CPU: 1 passed. With the
schedule_batch.pychange reverted: 1 failed.Speed Tests and Profiling
No hot-path change beyond the fix itself; not separately benchmarked.
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): ✅ Run #36767650274
Latest PR Test (Extra): ❌ Run #36767649664
Latest PR Test (AMD ROCm 10): ❌ Run #36767650253